-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(example-opencensus-shim): avoid OpenCensus auto instrumentations #3951
fix(example-opencensus-shim): avoid OpenCensus auto instrumentations #3951
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 92.91% 92.92% +0.01%
==========================================
Files 297 297
Lines 8838 8838
Branches 1815 1815
==========================================
+ Hits 8212 8213 +1
+ Misses 626 625 -1 |
How is this causing build failures if it is just an example? The code should not run as part of any build. This PR broke the example, following the instructions it no longer runs. |
…tations (open-telemetry#3951)" This reverts commit 15ede47.
…tations (open-telemetry#3951)" This reverts commit 15ede47.
Opened a PR to revert. Let's discuss there |
Which problem is this PR solving?
Currently the opencensus-shim example imports
@opencensus/nodejs
which also imports@opencensus/instrumentation-all
andgrpc
and causes build fails on many platforms.Short description of the changes
Changed
@opencensus/nodejs
to@opencensus/nodejs-base
which does not include instrumentations.Type of change
Please delete options that are not relevant.
Checklist: